chore!: rename role -> membership #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: Fixes Suggestion: rename `role` to `membership` #163
EvanHahn
approved these changes
Feb 19, 2024
|
Let me know if you want me to take another look at this. |
|
@EvanHahn Do we want to maybe do this before v1 (e.g. before MVP), simply to avoid a breaking change post-mvp? I realize it's confusing - this doesn't change the encoded proto format, but it is a breaking change for the decoded data because of the rename. |
|
This is a good change but I don't think we should delay the MVP, even though it's probably a small amount of work to integrate. Personally, I would punt this to post-MVP. |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: Fixes Suggestion: rename
roletomembership#163This will require changes to mapeo-core-next before releasing.